Take a look at our
ThinkPads.com HOME PAGE
For those who might want to contribute to the blog, start here: Editors Alley Topic
Then contact Bill with a Private Message

Search found 32 matches

by mjg59
Mon Nov 11, 2019 10:06 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

can you elaborate your statement? Why should user care of xxx mitigations? there is _no_ real-world exploits for such cases, and even if there were: a) one must use unsafe code from 3rd parties (and this leads to more some reeaaaaly dangerous problems) b) be a server with multiple VMs which are use...
by mjg59
Tue Jul 30, 2019 5:09 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

(Also it's really simple to get the other hotkeys to send stuff, so I have no idea why the original code doesn't…)
by mjg59
Tue Jul 30, 2019 5:08 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

In non-battery news, I've managed to get the EC to send reports for other hotkeys - I'm still trying to figure out a couple of details to ensure it sends the correct ones, and I'm a touch delayed because I forgot to fix up the checksum before reflashing so now I need to dig out my dediprog.
by mjg59
Mon Jul 29, 2019 1:39 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

Hmm, I'm not sure - the value here is coming directly from the battery without being interpreted by the EC, so that would depend on the battery reporting broken units. Which certainly isn't impossible, but the numbers you're seeing with my patch are much closer to the numbers I see with a 9-cell bat...
by mjg59
Sun Jul 28, 2019 1:04 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

Ok, can you try with https://github.com/mjg59/coreboot/commit/ff1e4531879d013c2e22a032d85bb89b6ab3e3f5 instead of the original patch? The values here look plausible to me, but the 14.4V is going to result in your power_now value going up a *lot* (your battery is actually reporting that it's discharg...
by mjg59
Sun Jul 28, 2019 12:38 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

Huh. Ok, the command the EC is sending is definitely the one to retrieve current, but… oh bother. Right. There are some commands that always return information in mA, and this is one. Other commands return something that depends on the unit set in the battery config. I'd bet that the battery is conf...
by mjg59
Sun Jul 28, 2019 12:24 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

Great. Thanks a lot! One question: why do you enable hotplug for the wireless card root port? And not, say, for the NVMe port as well? Or for no port at all, since these cards are not meant to be hotplugged anyway? Oh ha good catch. The connector on my board is slightly bad - I need to physically p...
by mjg59
Sun Jul 28, 2019 12:21 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

Ok, https://github.com/mjg59/coreboot/commit/05e21b7dcba12323f3a0ca7e74990bd837051263 works for me - energy_full_design matches the expected value. Awesome! ACPI is definitely where the issue should be dealt with. However I have a feeling that changing mah to mwh is not enough. Now power consumptio...
by mjg59
Sun Jul 28, 2019 12:16 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

flyingfishfinger wrote:
Sun Jul 28, 2019 12:29 am
Nice!

Random q, why is this in the applesmc branch? For that matter, which branch have you merged harryk's latest changes into, as indicated in the other thread?

R
Oh, just because that's the one I'm running. It includes Harry's changes, but so does x210_test.
by mjg59
Sat Jul 27, 2019 4:07 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

Ok, the solution to the battery conundrum lies in the Linux kernel sources: in drivers/acpi/battery.c On Lenovo Thinkpad models from 2010 and 2011, the power unit switches between mWh and mAh depending on whether the system is running on battery or not. When mAh is the unit, most reported values ar...
by mjg59
Sat Jul 27, 2019 2:22 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

Hi, all these things are in src/mainboard/51nb/x210/devicetree.cb My changes can be seen here: https://github.com/mjg59/coreboot/compare/x210_test...harrykipper:x210_test#diff-9076bfdaf603464700578c2eae28c511 Thanks, I'll merge these in! Ok, merged these with the following exceptions: 1) I've left ...
by mjg59
Sat Jul 27, 2019 1:30 am
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

harryK wrote:
Fri Jul 26, 2019 1:58 pm
Hi,

all these things are in src/mainboard/51nb/x210/devicetree.cb My changes can be seen here: https://github.com/mjg59/coreboot/compa ... 2eae28c511
Thanks, I'll merge these in!
by mjg59
Fri Jul 26, 2019 1:02 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

flyingfishfinger wrote:
Fri Jul 26, 2019 12:56 pm
Wow this sounds awesome! Have Matthew's changes been merged into coreboot master? His own Github master latest is 3 months old...
https://review.coreboot.org/c/coreboot/+/32531 is the ongoing review.
by mjg59
Fri Jul 26, 2019 1:01 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

Is it possible to add fn+ctrl swap? No, that's a function of the embedded controller, which is still running proprietary firmware. And the last one, has anyone tried the libgfxinit (there are some pending patches, but still)? libgfxinit works for cold boots, but fails to reinitialise the screen on ...
by mjg59
Fri Jul 19, 2019 7:07 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

mjg59 wrote:
Fri Jul 19, 2019 4:33 pm
harryK wrote:
Thu Jul 11, 2019 4:21 am
2. Another strange thing is that the processor seems to have lost support for Energy performance bias:
Huh weird. There's presumably some setup required that Coreboot's not doing - I'll look into that.
darn Intel. https://review.coreboot.org/c/coreboot/+/34458 should fix that.
by mjg59
Fri Jul 19, 2019 4:33 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

L1 substates can be enabled turning on support for the esoteric ClkReqNumber in devicetree.cb The following configuration works: Thanks! I'll merge that. 2. Another strange thing is that the processor seems to have lost support for Energy performance bias: Huh weird. There's presumably some setup r...
by mjg59
Fri May 24, 2019 3:23 am
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

But also you have: +# CONFIG_DRIVERS_PS2_KEYBOARD is not set which is definitely a problem :) You probably also want CONFIG_RUN_FSP_GOP=y if you're running Tiano as a payload, along with: CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y CONFIG_LINEAR_FRAMEBUFFER=y I basically haven't tested SeaBIOS as a payload,...
by mjg59
Fri May 24, 2019 3:15 am
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

First boot after reflashing may take up to a minute for RAM link calibration - how long did you wait?
by mjg59
Wed May 22, 2019 10:49 am
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

vladisslav2011 wrote:
Tue May 21, 2019 6:03 pm
The algorithm is very simple: 32bit sum of all firmware bytes (count FIRMW_SIZE*2 starting at FIRMW_START).
https://pastebin.com/ZjUUDdQ6
Great, thank you!
by mjg59
Sun May 19, 2019 10:11 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

Could you please also share your Ghidra/whatever project file to aid further mapping and modification of the EC firmware? The stock firmware is a piece of crap. It contains legacy code, ported from 51/31 microcontrollers, parts of some buggy libraries, many quick patches and lots of bugs. I have no...
by mjg59
Sat May 11, 2019 5:16 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 fan and battery communications
Replies: 8
Views: 1244

Re: X210 fan and battery communications

https://forum.51nb.com/forum.php?mod=re ... d=32315397 suggests that they're working on the charging issue, but there's been no release yet. Nuvoton are, it turns out, unenthusiastic about giving out docs for these parts even to companies that have NDAs…
by mjg59
Sat May 11, 2019 5:08 pm
Forum: 51nb and other modded Thinkpads
Topic: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)
Replies: 95
Views: 8127

Re: X210 EC datasheet/better brightness control?

The EC firmware is at offset 0x200000 in the flash, so can theoretically just be replaced with flashrom without touching anything else. And (on my batch 2 board, at least) the flash can be rewritten in situ without needing to desolder the chip - you just need a SOIC clip and a programmer. However, i...
by mjg59
Sat May 04, 2019 3:00 pm
Forum: 51nb and other modded Thinkpads
Topic: NVME on x210
Replies: 5
Views: 882

Re: NVME on x210

The NVMe slot is under the palm rest - you need to remove all the screws with the card logo on them, and then it's clipped in at the sides and along the front of the laptop. The X201 maintenance manual should show you how to do it. There's no 3G modem on board, but the mini-PCIe slot that you can se...
by mjg59
Tue Apr 30, 2019 9:35 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

(Oops, duplicate)
by mjg59
Tue Apr 30, 2019 9:32 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

No, this machine has never had an external flasher connected (we did the initial port on another machine and did use a flasher there). I've switched between stock and coreboot several times using -p internal.
by mjg59
Mon Apr 29, 2019 8:45 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

Ok, uploaded stuff to https://github.com/mjg59/coreboot/releases/tag/x210_1.0 - the coreboot.rom image there can be flashed directly using Flashrom with current git: sudo flashrom -p internal:laptop=force_I_want_a_brick -w coreboot.rom Note that, as the argument suggests, this might go horribly wron...
by mjg59
Mon Apr 29, 2019 4:47 pm
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

The issue with the wifi card turned out to be mechanical. I'm in the process of rebasing this on current upstream and will post some binaries once I'm done.
by mjg59
Mon Aug 20, 2018 1:06 am
Forum: 51nb and other modded Thinkpads
Topic: Coreboot on the X210
Replies: 69
Views: 5555

Re: Coreboot on the X210

I'll post binaries shortly - I'm just trying to track down an issue where everything works fine on my machine but wlan doesn't show up on another (nominally identical) board.

Go to advanced search