Take a look at our
ThinkPads.com HOME PAGE
For those who might want to contribute to the blog, start here: Editors Alley Topic
Then contact Bill with a Private Message

X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

Old(er) Thinkpads with New(er) Intestines: X62 / T50 / T70 / etc.
Message
Author
L29Ah
Freshman Member
Posts: 116
Joined: Fri Sep 06, 2013 2:25 pm
Location: Moscow, Russia

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#91 Post by L29Ah » Sun Sep 08, 2019 8:25 pm

I get 3.8W on lowest backlight and associated wifi. 3.5W with deassociated. All the ASPM is enabled, but i still never reach pc9 and pc10.
Out-of-tree r8168 module is necessary for ASPM support.
51nb X210 with community EC mod, me_cleaner and recelled 99W*h battery; X230 with coreboot, me_cleaner and nitrocaster's FHD mod as a backup; R500 for guests; T60 just for the looks.

vladisslav2011
Posts: 30
Joined: Fri Oct 12, 2018 6:33 am
Location: Velikiye Luki, Pskov, Russia

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#92 Post by vladisslav2011 » Mon Sep 09, 2019 4:47 pm

L29Ah wrote:
Sun Sep 08, 2019 8:25 pm
I get 3.8W on lowest backlight and associated wifi. 3.5W with deassociated. All the ASPM is enabled, but i still never reach pc9 and pc10.
As your LCD does not support PSR, then you will get pc9 only when the LCD is in DPMS off state (and wifi is disconnected).
You may start powertop, issue

Code: Select all

xset dpms force off
in separate terminal, wait a minute, press any key to wake the display and see results.

L29Ah
Freshman Member
Posts: 116
Joined: Fri Sep 06, 2013 2:25 pm
Location: Moscow, Russia

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#93 Post by L29Ah » Mon Sep 09, 2019 7:27 pm

I've brought up some infra for comfortable patch selection and application: https://github.com/l29ah/x210-ec
It would be cool if you submit your patches/pull requests to avoid throwing lots of differing and poorly documented blobs around that bring a lot of changes and are a pain to merge.
51nb X210 with community EC mod, me_cleaner and recelled 99W*h battery; X230 with coreboot, me_cleaner and nitrocaster's FHD mod as a backup; R500 for guests; T60 just for the looks.

L29Ah
Freshman Member
Posts: 116
Joined: Fri Sep 06, 2013 2:25 pm
Location: Moscow, Russia

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#94 Post by L29Ah » Tue Sep 10, 2019 6:54 am

rm
51nb X210 with community EC mod, me_cleaner and recelled 99W*h battery; X230 with coreboot, me_cleaner and nitrocaster's FHD mod as a backup; R500 for guests; T60 just for the looks.

L29Ah
Freshman Member
Posts: 116
Joined: Fri Sep 06, 2013 2:25 pm
Location: Moscow, Russia

Re: X210 EC datasheet/better brightness control?

#95 Post by L29Ah » Thu Sep 12, 2019 7:24 pm

vladisslav2011 wrote:
Fri Sep 06, 2019 11:55 am
verynice wrote:
Fri Sep 06, 2019 3:02 am
Is it possible to set the bat thresholds with EC?
If you want to undercharge the battery to prolong it's life, then it may be done already. :-) At least my laptop is constantly undercharging the battery by several parcent.
My X210 charges the battery to 4.16 per cell, while ~4V ceiling during typical use would make more sense: it's only ~25% less energy but only ~20% cycle wear compared to 4.2V cycles, also less time-based degradation.
51nb X210 with community EC mod, me_cleaner and recelled 99W*h battery; X230 with coreboot, me_cleaner and nitrocaster's FHD mod as a backup; R500 for guests; T60 just for the looks.

mjg59
Posts: 32
Joined: Sat Aug 21, 2004 7:53 am

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#96 Post by mjg59 » Tue Nov 12, 2019 11:54 pm

I've posted a pull request at https://github.com/l29ah/x210-ec/pull/1 that allows the remaining hotkeys to be used under Linux.

L29Ah
Freshman Member
Posts: 116
Joined: Fri Sep 06, 2013 2:25 pm
Location: Moscow, Russia

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#97 Post by L29Ah » Fri Nov 22, 2019 4:31 pm

Is it me or the EC sometimes forgets how to send the power button events?
51nb X210 with community EC mod, me_cleaner and recelled 99W*h battery; X230 with coreboot, me_cleaner and nitrocaster's FHD mod as a backup; R500 for guests; T60 just for the looks.

L29Ah
Freshman Member
Posts: 116
Joined: Fri Sep 06, 2013 2:25 pm
Location: Moscow, Russia

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#98 Post by L29Ah » Mon Nov 25, 2019 2:21 am

Idea for an EC patch: currently the battery LED blinks green when the battery is almost discharged and blinks orange when it's charging from such a state; it should be the other way around to bring attention when it should.
51nb X210 with community EC mod, me_cleaner and recelled 99W*h battery; X230 with coreboot, me_cleaner and nitrocaster's FHD mod as a backup; R500 for guests; T60 just for the looks.

flyingfishfinger
Junior Member
Junior Member
Posts: 331
Joined: Sun Nov 18, 2012 5:42 pm
Location: San Francisco Bay Area

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#99 Post by flyingfishfinger » Mon Dec 23, 2019 4:52 pm

Hi,
I've found a funny issue with vladisslav2011's EC. I built an otherwise working coreboot image against the latest master.

On Linux, I get 14 brightness steps and everything works great.

On Windows (10) brightness control doesn't work at all. It still registers the key events in that I see the on-screen brightness slider change, but it only has 10 steps and no effect on actual screen brightness.

I'm not sure where along the way this broke, but I'm 100% certain when I first started playing with the coreboot builds this worked properly in Windows. Hence my surprise that it no longer does.

Anyone have an idea why it would work fine in Linux, but not in Windows?

Cheers,
R

L29Ah
Freshman Member
Posts: 116
Joined: Fri Sep 06, 2013 2:25 pm
Location: Moscow, Russia

Re: X210 embedded controller fixes (was: X210 EC datasheet/better brightness control)

#100 Post by L29Ah » Wed Dec 25, 2019 6:27 am

L29Ah wrote:
Fri Nov 22, 2019 4:31 pm
Is it me or the EC sometimes forgets how to send the power button events?
Okay, it was ME that have [censored] itself somehow; reflashing its region with its original firmware have fixed the problem.
51nb X210 with community EC mod, me_cleaner and recelled 99W*h battery; X230 with coreboot, me_cleaner and nitrocaster's FHD mod as a backup; R500 for guests; T60 just for the looks.

Post Reply
  • Similar Topics
    Replies
    Views
    Last post

Return to “51nb and other modded Thinkpads”

Who is online

Users browsing this forum: No registered users and 2 guests