T420 incompatible with tp_smapi?

[chx1975]

I upgraded to latest BIOS 83ET52WW (1.22 ) but loading tp_smapi (actually thinkpad_ec) still results in FATAL: Error inserting thinkpad_ec (/lib/modules/2.6.38-ARCH/extra/thinkpad_ec.ko.gz): No such device or in dmesg thinkpad_ec: no ThinkPad embedded controller!


uname -a

Linux veyron2 2.6.38-ARCH #1 SMP PREEMPT Sun Apr 17 15:18:58 CEST 2011 x86_64 Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz GenuineIntel GNU/Linux

[chx1975]

http://lists.freebsd.org/pipermail/free ... 84573.html solves it:

Code: Select all

--- thinkpad_ec.orig    2011-04-28 13:30:44.759955841 -0700
+++ thinkpad_ec.c       2011-04-28 13:31:32.539954894 -0700
@@ -471,11 +471,13 @@
 
 static int __init thinkpad_ec_init(void)
 {
+/*
        if (!check_dmi_for_ec()) {
                printk(KERN_WARNING
                       "thinkpad_ec: no ThinkPad embedded controller!\n");
                return -ENODEV;
        }
+*/
 
        if (request_region(TPC_BASE_PORT, TPC_NUM_PORTS, "thinkpad_ec")) {
                reserved_io = 1;

[chx1975]

However, charging tresholds or force discharge can't be set :smapi_request: SMAPI error: SMAPI fuction is not available (func=2116)

yes, fuction... (force discharge is 2118, otherwise the same)

Reading various bits seems to work, manufacture date is 2011-03-19, the serial is 479, is this the #479 T420 in the world ?

All in all, without any charge control, it's utterly useless.

Handle 0x0027, DMI type 126, 9 bytes
Inactive

Interesting.

[boltzmann]

http://lists.freebsd.org/pipermail/free ... 84573.html solves it:

Code: Select all

--- thinkpad_ec.orig    2011-04-28 13:30:44.759955841 -0700
+++ thinkpad_ec.c       2011-04-28 13:31:32.539954894 -0700
@@ -471,11 +471,13 @@
 
 static int __init thinkpad_ec_init(void)
 {
+/*
        if (!check_dmi_for_ec()) {
                printk(KERN_WARNING
                       "thinkpad_ec: no ThinkPad embedded controller!\n");
                return -ENODEV;
        }
+*/
 
        if (request_region(TPC_BASE_PORT, TPC_NUM_PORTS, "thinkpad_ec")) {
                reserved_io = 1;

Cannot apply the patch:

Code: Select all

 
$ patch < diff
patching file thinkpad_ec.c
patch: **** malformed patch at line 5: static int __init thinkpad_ec_init(void)

What am I doing wrong?

[comps]

What am I doing wrong?

Probably using copy&paste from here, the file actual file has tabs whereas the patch posted here is malformed (uses spaces), so either comment that check manually or get a correct patch.

[ThinkRob]

That's also not the best way to hack around it...

Personally I'd add a line to 'tp_whitelist' in check_dmi_for_ec(void)